How to modify if the custom carrier board does not use GPIO to control vdd_3v3_pcie and vdd_12v_pcie?

Is the following modification correct?

Original in Linux_for_Tegra/source/hardware/nvidia/t23x/nv-public/tegra234-p3701-0000.dtsi:
vdd_3v3_pcie: regulator-vdd-3v3-pcie {
compatible = “regulator-fixed”;
regulator-name = “VDD_3V3_PCIE”;
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
gpio = <&gpio TEGRA234_MAIN_GPIO(H, 4) GPIO_ACTIVE_HIGH>;
regulator-boot-on;
enable-active-high;
};

vdd_12v_pcie: regulator-vdd-12v-pcie {
compatible = “regulator-fixed”;
regulator-name = “VDD_12V_PCIE”;
regulator-min-microvolt = <12000000>;
regulator-max-microvolt = <12000000>;
gpio = <&gpio TEGRA234_MAIN_GPIO(A, 1) GPIO_ACTIVE_LOW>;
regulator-boot-on;
};

Modified to:

vdd_3v3_pcie: regulator-vdd-3v3-pcie {
compatible = “regulator-fixed”;
regulator-name = “VDD_3V3_PCIE”;
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
regulator-always-on;
};

vdd_12v_pcie: regulator-vdd-12v-pcie {
compatible = “regulator-fixed”;
regulator-name = “VDD_12V_PCIE”;
regulator-min-microvolt = <12000000>;
regulator-max-microvolt = <12000000>;
regulator-always-on;
};

Is this correct?

Hi idealong,

Are you using the devkit or custom board for AGX Orin?
What’s the Jetpack version in use?

Yes, this is correct if both PCIe rails are always on by hardware. Remove the GPIO control and use fixed regulators with regulator-always-on. If your board does not have 12V PCIe, remove vpcie12v-supply from the PCIe node instead of keeping a dummy regulator.