Latest beta drivers fail to build with linux-next tree

Graphics / Linux Linux
1

Hello,

latest drivers fail to build with current linux-next tree (unsupported, I know):

/home/tomas/nvidia/kernel/nv-procfs.c: In function 'nv_procfs_read_registry':
/home/tomas/nvidia/kernel/nv-procfs.c:361:12: error: void value not ignored as it ought to be
     return seq_printf(s, "Binary: \"%s\"\n", registry_keys);
            ^
/home/tomas/nvidia/kernel/nv-procfs.c: In function 'nv_procfs_read_text_file':
/home/tomas/nvidia/kernel/nv-procfs.c:561:12: error: void value not ignored as it ought to be
     return seq_puts(s, s->private);

Probably related to this commit:

commit 14c4730e8a5c385b99e3a09851a277d7180f4bb5
Author: Joe Perches <joe@perches.com>
Date:   Fri Jun 19 09:05:41 2015 +1000

    fs/seq_file: convert int seq_vprint/seq_printf/etc... returns to void
    
    The seq_<foo> function return values were frequently misused.
    
    See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to
         seq_has_overflowed() and make public")
    
    All uses of these return values have been removed, so convert the
    return types to void.
    
    Miscellanea:
    
    o Move seq_put_decimal_<type> and seq_escape prototypes closer the
      other seq_vprintf prototypes
    o Reorder seq_putc and seq_puts to return early on overflow
    o Add argument names to seq_vprintf and seq_printf
    o Update the seq_escape kernel-doc
    o Convert a couple of leading spaces to tabs in seq_escape
    
    Signed-off-by: Joe Perches <joe@perches.com>
    Cc: Al Viro <viro@ZenIV.linux.org.uk>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2

I ran into this as well. I just made the two offending functions return 0 and haven’t seen any issues so far. Here’s a patch:

--- nv-procfs.c	2015-08-14 18:54:51.000000000 -0500
+++ /opt/NVIDIA-Linux-x86_64-352.39/kernel/nv-procfs.c	2016-01-11 15:13:23.311369524 -0600
@@ -358,7 +358,8 @@
     registry_keys = ((nvl != NULL) ?
             nvl->registry_keys : nv_registry_keys);
 
-    return seq_printf(s, "Binary: \"%s\"\n", registry_keys);
+    seq_printf(s, "Binary: \"%s\"\n", registry_keys);
+    return 0;
 }
 
 static ssize_t
@@ -558,7 +559,8 @@
     void *v
 )
 {
-    return seq_puts(s, s->private);
+    seq_puts(s, s->private);
+    return 0;
 }
 
 NV_DEFINE_PROCFS_SINGLE_FILE(text_file);
3

Shouldn’t that return seq_has_overflowed()?

4

Hi,

I get the same issue when trying to install cuda_7.5.18_linux.run on Ubuntu 16.04. Is there a way to fix that. When I extract the archive with ./cuda_7.5.18_linx.run I get a bunch of .run, .pc and .pl files but none of the files that are mentioned above.

5

cuda_7.5.18_linx.run worked for ubuntu 14.04 but is failing to install in 16.04 with

/tmp/selfgz5515/NVIDIA-Linux-x86_64-352.39/kernel/nv-procfs.c:361:12: error: void value not ignored as it ought to be
        return seq_printf(s, "Binary: \"%s\"\n", registry_keys);

I am running a headless cuda-powered GPU render engine with GTX 970s for blender projects.

How can I get access to dev code with the above commits?