Hello, I am configuring wm8904 audio on R32.5.1. I have encountered a problem and need your help. Thank you.
I configured the following attribute in the device tree
nvidia,dai-link-5 {
codec-dai-name = "wm8904-hifi";
};
and the wm8904. c file also has a “. name” attribute
static struct snd_soc_dai_driver wm8904_dai = {
.name = "wm8904-hifi";
};
So why do I still have the following alarms
Are there any other configuration items for wm8904-hifi registration
The entries mentioned above are not sufficient.
Please follow the BSP documentation to add custom audio card.
NVIDIA Jetson Linux Developer Guide : Audio Setup and Development | NVIDIA Docs
You can get some hints on how to add wm8904 card from WM8904 audio driver support for Jetson TX2 NX - Jetson & Embedded Systems / Jetson TX2 - NVIDIA Developer Forums, but please note it is on different Jetson module.
For codec specific info, please contact codec vendor directly.
@Yolomei ,Hello,I also recently used WM8904 instead of RT5658 in Jetson AGX Xavier, mounted under the i2c@c250000 node, how do you configure the device tree and WM8904? Can you provide references? Let the wm8904 sound normally, thank you
You can refer to rt565x and add wm8904 information in the “tegra_machine_driver. c” file
Hello, I would like to ask, can you send me the WM8904 codec related device tree and driver files? Because I didn’t make any progress for a few days. Thank you and hope to get your help.
Where do you don’t understand? You can communicate with me. I just debugged it to play sound, but there is an error
@Yolomei ,Hello,Thank you so much,The device tree I modified in Jetson AGX Xavier is as follows, I would like to ask if it is correct?
// SPDX-License-Identifier: GPL-2.0-only
/*
* T194 p2822-0000 audio common DTSI file.
*
* Copyright (c) 2017-2022, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
*
*/
#include <audio/tegra-platforms-audio-dai-links.dtsi>
#include <audio/tegra186-audio-dai-links.dtsi>
#include <audio/tegra186-audio-graph.dtsi>
#include <dt-bindings/gpio/tegra194-gpio.h>
#include <dt-bindings/audio/tegra194-audio.h>
#include <audio/tegra-platforms-audio-dmic3-5-switch.dtsi>
/ {
aconnect@2a41000 {
status = "okay";
agic-controller@2a41000 {
status = "okay";
};
adsp@2993000 {
status = "okay";
};
};
//add
clocks {
wm8904_mclk: wm8904_mclk {
compatible = "fixed-clock";
#clock-cells = <0>;
// clock-frequency = <49152000>;
clock-frequency = <12288000>;
clock-output-names = "wm8904-mclk";
status = "okay";
};
};
i2c@c250000 {
//add
wm8904_codec: wm8904@1a {
compatible = "wlf,wm8904";
status ="okay";
reg = <0x1a>;
clocks = <&wm8904_mclk>;
// clocks = <&bpmp TEGRA194_CLK_AUD_MCLK>;
// clocks = <&pck0>;
clock-names = "mclk";
port {
wm8904_ep: endpoint {
remote-endpoint = <&i2s1_dap_ep>;
mclk-fs = <256>;
link-name = "wm8904-playback";
};
};
};
};
/* Default for all I2S is long fsync width(31) */
aconnect@2a41000 {
compatible = "nvidia,tegra210-aconnect";
status = "okay";
ahub {
/* I2S4 in Short frame sync for BT SCO */
i2s@2901300 {
bclk-ratio = <4>;
status = "okay";
};
};
};
tegra_acsl_audio: acsl_audio {
status = "okay";
};
hda@3510000 {
status = "okay";
nvidia,model = "NVIDIA Jetson AGX Xavier HDA";
};
tegra_sound: sound {
status = "okay";
compatible = "nvidia,tegra186-ape";
nvidia-audio-card,name = "NVIDIA Jetson AGX Xavier APE";
nvidia,num-codec-link = <1>;
nvidia,num-clk = <6>;
nvidia,clk-rates = < 270950400 /* PLLA_x11025_RATE */
11289600 /* AUD_MCLK_x11025_RATE */
45158400 /* PLLA_OUT0_x11025_RATE */
45158400 /* AHUB_x11025_RATE */
245760000 /* PLLA_x8000_RATE */
12288000 /* AUD_MCLK_x8000_RATE */
49152000 /* PLLA_OUT0_x8000_RATE */
49152000 >;/* AHUB_x8000_RATE */
nvidia,xbar = <&tegra_axbar>;
clocks = <&bpmp_clks TEGRA194_CLK_PLLA>,
<&bpmp_clks TEGRA194_CLK_PLLA_OUT0>,
<&bpmp_clks TEGRA194_CLK_AUD_MCLK>;
clock-names = "pll_a", "pll_a_out0", "extern1";
assigned-clocks = <&bpmp_clks TEGRA194_CLK_AUD_MCLK>;
assigned-clock-parents = <&bpmp_clks TEGRA194_CLK_PLLA_OUT0>;
nvidia-audio-card,widgets =
"Headphone", "WM Headphone Jack",
"Microphone", "WM Mic",
"Line", "WM Line In Jack",
"Line", "WM Line In Jack",
"Microphone", "WM MICBIAS";
//add
nvidia-audio-card,routing =
"WM Headphone Jack", "WM HPOUTL",
"WM Headphone Jack", "WM HPOUTR",
"WM IN2L", "WM Line In Jack",
"WM IN2R", "WM Line In Jack",
"WM Mic", "WM MICBIAS",
"WM IN1L", "WM Mic";
// "x Headphone", "x HPOUTL",
// "x Headphone", "x HPOUTR";
nvidia-audio-card,mclk-fs = <256>;
nvidia,dai-link-1 {
link-name = "wm8904-playback";
cpu-dai = <&tegra_i2s1>;
codec-dai = <&wm8904_codec>;
cpu-dai-name = "I2S1";
codec-dai-name = "wm8904-hifi";
format = "i2s";
bitclock-slave;
frame-slave;
bitclock-noninversion;
frame-noninversion;
bit-format = "s16_le";
bclk_ratio = <0>;
srate = <48000>;
num-channel = <2>;
ignore_suspend;
name-prefix = "WM";
status = "okay";
};
};
tegra_sound_graph: sound_graph {
compatible = "nvidia,tegra186-audio-graph-card";
/*
* Tegra audio graph card is based on uptream generic audio
* graph sound card. In future there is plan to use this
* as default sound card.
*/
status = "disabled";
dais = /* ADMAIF (FE) Ports */
<&admaif1_port>, <&admaif2_port>, <&admaif3_port>,
<&admaif4_port>, <&admaif5_port>, <&admaif6_port>,
<&admaif7_port>, <&admaif8_port>, <&admaif9_port>,
<&admaif10_port>, <&admaif11_port>, <&admaif12_port>,
<&admaif13_port>, <&admaif14_port>, <&admaif15_port>,
<&admaif16_port>, <&admaif17_port>, <&admaif18_port>,
<&admaif19_port>, <&admaif20_port>,
/* ADSP (FE) Ports */
<&adsp_pcm1_port>, <&adsp_pcm2_port>,
<&adsp_compr1_port>, <&adsp_compr2_port>,
/* XBAR I/O ports */
<&xbar_i2s1_port>, <&xbar_i2s2_port>, <&xbar_i2s3_port>,
<&xbar_i2s4_port>, <&xbar_i2s5_port>, <&xbar_i2s6_port>,
<&xbar_dmic1_port>, <&xbar_dmic2_port>,
<&xbar_dmic3_port>, <&xbar_dmic4_port>,
<&xbar_dspk1_port>, <&xbar_dspk2_port>,
/* XBAR HW accelerator ports */
<&xbar_sfc1_in_port>, <&xbar_sfc2_in_port>,
<&xbar_sfc3_in_port>, <&xbar_sfc4_in_port>,
<&xbar_mvc1_in_port>, <&xbar_mvc2_in_port>,
<&xbar_afc1_in_port>, <&xbar_afc2_in_port>,
<&xbar_afc3_in_port>, <&xbar_afc4_in_port>,
<&xbar_afc5_in_port>, <&xbar_afc6_in_port>,
<&xbar_asrc_in1_port>, <&xbar_asrc_in2_port>,
<&xbar_asrc_in3_port>, <&xbar_asrc_in4_port>,
<&xbar_asrc_in5_port>, <&xbar_asrc_in6_port>,
<&xbar_asrc_in7_port>, <&xbar_arad_port>,
<&xbar_mixer_in1_port>, <&xbar_mixer_in2_port>,
<&xbar_mixer_in3_port>, <&xbar_mixer_in4_port>,
<&xbar_mixer_in5_port>, <&xbar_mixer_in6_port>,
<&xbar_mixer_in7_port>, <&xbar_mixer_in8_port>,
<&xbar_mixer_in9_port>, <&xbar_mixer_in10_port>,
<&xbar_ope1_in_port>,
<&xbar_amx1_in1_port>, <&xbar_amx1_in2_port>,
<&xbar_amx1_in3_port>, <&xbar_amx1_in4_port>,
<&xbar_amx2_in1_port>, <&xbar_amx2_in2_port>,
<&xbar_amx2_in3_port>, <&xbar_amx2_in4_port>,
<&xbar_amx3_in1_port>, <&xbar_amx3_in2_port>,
<&xbar_amx3_in3_port>, <&xbar_amx3_in4_port>,
<&xbar_amx4_in1_port>, <&xbar_amx4_in2_port>,
<&xbar_amx4_in3_port>, <&xbar_amx4_in4_port>,
<&xbar_adx1_in_port>, <&xbar_adx2_in_port>,
<&xbar_adx3_in_port>, <&xbar_adx4_in_port>,
/* BE I/O Ports */
<&i2s1_port>, <&i2s2_port>, <&i2s3_port>,
<&i2s4_port>, <&i2s5_port>, <&i2s6_port>,
<&dmic1_port>, <&dmic2_port>, <&dmic3_port>,
<&dmic4_port>,
<&dspk1_port>, <&dspk2_port>,
/* BE HW accelerator ports */
<&sfc1_out_port>, <&sfc2_out_port>,
<&sfc3_out_port>, <&sfc4_out_port>,
<&mvc1_out_port>, <&mvc2_out_port>,
<&afc1_out_port>, <&afc2_out_port>,
<&afc3_out_port>, <&afc4_out_port>,
<&afc5_out_port>, <&afc6_out_port>,
<&asrc_out1_port>, <&asrc_out2_port>,
<&asrc_out3_port>, <&asrc_out4_port>,
<&asrc_out5_port>, <&asrc_out6_port>,
<&mixer_out1_port>, <&mixer_out2_port>,
<&mixer_out3_port>, <&mixer_out4_port>,
<&mixer_out5_port>,
<&ope1_out_port>,
<&amx1_out_port>, <&amx2_out_port>,
<&amx3_out_port>, <&amx4_out_port>,
<&adx1_out1_port>, <&adx1_out2_port>,
<&adx1_out3_port>, <&adx1_out4_port>,
<&adx2_out1_port>, <&adx2_out2_port>,
<&adx2_out3_port>, <&adx2_out4_port>,
<&adx3_out1_port>, <&adx3_out2_port>,
<&adx3_out3_port>, <&adx3_out4_port>,
<&adx4_out1_port>, <&adx4_out2_port>,
<&adx4_out3_port>, <&adx4_out4_port>,
/* ADSP related ports */
<&adsp_admaif1_port>, <&adsp_admaif2_port>,
<&adsp_admaif3_port>, <&adsp_admaif4_port>,
<&adsp_admaif5_port>, <&adsp_admaif6_port>,
<&adsp_admaif7_port>, <&adsp_admaif8_port>,
<&adsp_admaif9_port>, <&adsp_admaif10_port>,
<&adsp_admaif11_port>, <&adsp_admaif12_port>,
<&adsp_admaif13_port>, <&adsp_admaif14_port>,
<&adsp_admaif15_port>, <&adsp_admaif16_port>,
<&adsp_admaif17_port>, <&adsp_admaif18_port>,
<&adsp_admaif19_port>, <&adsp_admaif20_port>,
<&admaif1_codec_port>, <&admaif2_codec_port>,
<&admaif3_codec_port>, <&admaif4_codec_port>,
<&admaif5_codec_port>, <&admaif6_codec_port>,
<&admaif7_codec_port>, <&admaif8_codec_port>,
<&admaif9_codec_port>, <&admaif10_codec_port>,
<&admaif11_codec_port>, <&admaif12_codec_port>,
<&admaif13_codec_port>, <&admaif14_codec_port>,
<&admaif15_codec_port>, <&admaif16_codec_port>,
<&admaif17_codec_port>, <&admaif18_codec_port>,
<&admaif19_codec_port>, <&admaif20_codec_port>;
label = "NVIDIA Jetson AGX Xavier APE";
clocks = <&bpmp_clks TEGRA194_CLK_PLLA>,
<&bpmp_clks TEGRA194_CLK_PLLA_OUT0>;
clock-names = "pll_a", "plla_out0";
assigned-clocks = <&bpmp_clks TEGRA194_CLK_AUD_MCLK>;
assigned-clock-parents = <&bpmp_clks TEGRA194_CLK_PLLA_OUT0>;
widgets = "Headphone", "WM Headphone Jack",
"Microphone", "WM Mic",
"Line", "WM Line In Jack",
"Line", "WM Line In Jack",
"Microphone", "WM MICBIAS";
routing = "WM Headphone Jack", "WM HPOUTL",
"WM Headphone Jack", "WM HPOUTR",
"WM IN2L", "WM Line In Jack",
"WM IN2R", "WM Line In Jack",
"WM Mic", "WM MICBIAS",
"WM IN1L", "WM Mic";
/*
* For codec2codec based DAI link design this is required.
* For DPCM based design, this is optional and instead
* it will be picked from codec port node.
*/
mclk-fs = <256>;
};
};
/*
* Default config for all I2S dai links are
* format = "i2s", bitclock-slave, frame-slave,
* bitclock-noninversion, frame-noninversion,
* Any change from default needs override on
* platform specific files.
*/
/* Override with Codec entries */
&i2s1_to_codec {
link-name = "wm8904-playback";
// link-name = "rt5658-playback";
bitclock-master;
frame-master;
codec {
sound-dai = <&wm8904_codec 0>;
prefix = "WM";
};
};
hdr40_snd_link_i2s: &i2s2_to_codec { };
/* Override with BT SCO entries */
&i2s4_to_codec {
format = "dsp_a";
bitclock-inversion;
};
/* Audio graph related bindings */
&i2s1_dap_ep {
remote-endpoint = <&wm8904_ep>;
};
&i2s4_dap_ep {
dai-format = "dsp_a";
bitclock-inversion;
};
hdr40_snd_i2s_dap_ep: &i2s2_dap_ep { };
I made modifications to the tegra_machine_driver.c file as follows:
static int tegra_machine_wm8904_init(struct snd_soc_pcm_runtime *rtd)
{
struct device *dev = rtd->card->dev;
int err;
err = snd_soc_dai_set_sysclk(rtd->codec_dai, WM8904_CLK_MCLK, 12288000,
SND_SOC_CLOCK_IN);
if (err)
{
dev_err(dev, "failed to wm8904 sysclk !\n");
return err;
}
return 0;
}
static int codec_init(struct tegra_machine *machine)
{
struct snd_soc_dai_link *dai_links = machine->asoc->dai_links;
unsigned int num_links = machine->asoc->num_links, i;
if (!dai_links || !num_links)
return -EINVAL;
for (i = 0; i < num_links; i++)
{
if (!dai_links[i].name)
continue;
if (strstr(dai_links[i].name, "rt565x-playback") ||
strstr(dai_links[i].name, "rt565x-codec-sysclk-bclk1"))
dai_links[i].init = tegra_machine_rt565x_init;
else if (strstr(dai_links[i].name, "fe-pi-audio-z-v2"))
dai_links[i].init = tegra_machine_fepi_init;
else if (strstr(dai_links[i].name, "respeaker-4-mic-array"))
dai_links[i].init = tegra_machine_respeaker_init;
else if (strstr(dai_links[i].name, "wm8904-playback"))
dai_links[i].init = tegra_machine_wm8904_init;
}
return 0;
}
I added the following to Kconfig:
config SND_SOC_TEGRA210_AUDIO
tristate "SoC Audio support for Tegra210"
depends on I2C
depends on ARCH_TEGRA_210_SOC || ARCH_TEGRA_18x_SOC
select SND_SOC_RT5659
select SND_SOC_TAS2552
select SND_SOC_SGTL5000
select SND_SOC_WM8904
I would like to confirm that my modifications still need to add those? Does the wm8904 driver need to be compiled into the kernel? Or compile directly into modules and install them via sudo insmod wm8904.ko.thank you.
wm8904_codec: wm8904@1a {
clocks = <&bpmp_clks TEGRA194_CLK_AUD_MCLK>;
}；
/*
static struct snd_soc_dai_driver wm8904_dai = {
.name = "wm8904-hifi";
};
*/
nvidia,dai-link-1 {
codec-dai-name = "wm8904-hifi"; // .name = "wm8904-hifi";
};
//Kconfig
config SND_SOC_WM8904
tristate "Wolfson Microelectronics WM8904 CODE"
depends on I2C
Then, execute "make menuconfig" and select the added wm8904
@Yolomei ,thank you so mush,Here, whether this nvidia, dai-link-1 node is placed inside or outside tegra_sound: sound,
tegra_sound: sound {
status = "okay";
compatible = "nvidia,tegra186-ape";
nvidia-audio-card,name = "NVIDIA Jetson AGX Xavier APE";
nvidia,num-codec-link = <1>;
nvidia,num-clk = <6>;
nvidia,clk-rates = < 270950400 /* PLLA_x11025_RATE */
11289600 /* AUD_MCLK_x11025_RATE */
45158400 /* PLLA_OUT0_x11025_RATE */
45158400 /* AHUB_x11025_RATE */
245760000 /* PLLA_x8000_RATE */
12288000 /* AUD_MCLK_x8000_RATE */
49152000 /* PLLA_OUT0_x8000_RATE */
49152000 >;/* AHUB_x8000_RATE */
nvidia,xbar = <&tegra_axbar>;
clocks = <&bpmp_clks TEGRA194_CLK_PLLA>,
<&bpmp_clks TEGRA194_CLK_PLLA_OUT0>,
<&bpmp_clks TEGRA194_CLK_AUD_MCLK>;
clock-names = "pll_a", "pll_a_out0", "extern1";
assigned-clocks = <&bpmp_clks TEGRA194_CLK_AUD_MCLK>;
assigned-clock-parents = <&bpmp_clks TEGRA194_CLK_PLLA_OUT0>;
nvidia-audio-card,widgets =
"Headphone", "WM Headphone Jack",
"Microphone", "WM Mic",
"Line", "WM Line In Jack",
"Line", "WM Line In Jack",
"Microphone", "WM MICBIAS";
//add
nvidia-audio-card,routing =
"WM Headphone Jack", "WM HPOUTL",
"WM Headphone Jack", "WM HPOUTR",
"WM IN2L", "WM Line In Jack",
"WM IN2R", "WM Line In Jack",
"WM Mic", "WM MICBIAS",
"WM IN1L", "WM Mic";
// "x Headphone", "x HPOUTL",
// "x Headphone", "x HPOUTR";
nvidia-audio-card,mclk-fs = <256>;
nvidia,dai-link-1 {
link-name = "wm8904-playback";
cpu-dai = <&tegra_i2s1>;
codec-dai = <&wm8904_codec>;
cpu-dai-name = "I2S1";
codec-dai-name = "wm8904-hifi";
format = "i2s";
bitclock-slave;
frame-slave;
bitclock-noninversion;
frame-noninversion;
bit-format = "s16_le";
bclk_ratio = <0>;
srate = <48000>;
num-channel = <2>;
ignore_suspend;
name-prefix = "WM";
status = "okay";
};
};
Everything else should be correct？
link-name = “wm8904-playback”; Need to change link-name = “wm8904-hifi”?
The “link name” attribute remains unchanged; The “codec-dai-name” attribute should be consistent with the “. name” above;
yes, in it.
and add the following attributes
nvidia-audio-card,routing =
“WM Headphone”, “WM HPOUTL”,
“WM Headphone”, “WM HPOUTR”;
Personal suggestion: try not to change the source code, and add or delete all new attribute in the flash device tree
tegra_sound: sound {
status = "okay";
compatible = "nvidia,tegra186-ape";
nvidia-audio-card,name = "NVIDIA Jetson AGX Xavier APE";
nvidia,num-codec-link = <1>;
nvidia,num-clk = <6>;
nvidia,clk-rates = < 270950400 /* PLLA_x11025_RATE */
11289600 /* AUD_MCLK_x11025_RATE */
45158400 /* PLLA_OUT0_x11025_RATE */
45158400 /* AHUB_x11025_RATE */
245760000 /* PLLA_x8000_RATE */
12288000 /* AUD_MCLK_x8000_RATE */
49152000 /* PLLA_OUT0_x8000_RATE */
49152000 >;/* AHUB_x8000_RATE */
nvidia,xbar = <&tegra_axbar>;
clocks = <&bpmp_clks TEGRA194_CLK_PLLA>,
<&bpmp_clks TEGRA194_CLK_PLLA_OUT0>,
<&bpmp_clks TEGRA194_CLK_AUD_MCLK>;
clock-names = "pll_a", "pll_a_out0", "extern1";
assigned-clocks = <&bpmp_clks TEGRA194_CLK_AUD_MCLK>;
assigned-clock-parents = <&bpmp_clks TEGRA194_CLK_PLLA_OUT0>;
nvidia-audio-card,widgets =
"Headphone", "WM Headphone Jack",
"Microphone", "WM Mic",
"Line", "WM Line In Jack",
"Line", "WM Line In Jack",
"Microphone", "WM MICBIAS";
//add
nvidia-audio-card,routing =
"WM Headphone Jack", "WM HPOUTL",
"WM Headphone Jack", "WM HPOUTR",
"WM IN2L", "WM Line In Jack",
"WM IN2R", "WM Line In Jack",
"WM Mic", "WM MICBIAS",
"WM IN1L", "WM Mic",
"WM Headphone", "WM HPOUTL",
"WM Headphone", "WM HPOUTR";
nvidia-audio-card,mclk-fs = <256>;
nvidia,dai-link-1 {
link-name = "wm8904-playback";
cpu-dai = <&tegra_i2s1>;
codec-dai = <&wm8904_codec>;
cpu-dai-name = "I2S1";
codec-dai-name = "wm8904-hifi";
format = "i2s";
bitclock-slave;
frame-slave;
bitclock-noninversion;
frame-noninversion;
bit-format = "s16_le";
bclk_ratio = <0>;
srate = <48000>;
num-channel = <2>;
ignore_suspend;
name-prefix = "WM";
status = "okay";
};
};
Then there should be no problem with this modification, right?
You can flash the device tree and kernel first to see what errors will be reported
Thank you,ok,When I executed make ARCH=arm64 menuconfig, I found that the Wolfson Microelectronics WM8904 CODEC only had M and spaces, and I couldn’t check *, so I modified kconfig
config SND_SOC_WM8904
bool "Wolfson Microelectronics WM8904 CODEC"
default y
depends on I2C
➜ ~ sudo dmesg | grep 8904
[ 12.678496] rt5659 7-001a: Device with ID register 8904 is not rt5659
Hello,There are new developments, the wm8904 driver can be loaded, but the DMESG shows up
➜ ~ sudo dmesg | grep 8904
[sudo] password for nvidia:
[ 7.607438] wm8904 7-001a: supply DCVDD not found, using dummy regulator
[ 7.616702] wm8904 7-001a: supply DBVDD not found, using dummy regulator
[ 7.629127] wm8904 7-001a: supply AVDD not found, using dummy regulator
[ 7.641637] wm8904 7-001a: supply CPVDD not found, using dummy regulator
[ 7.654450] wm8904 7-001a: supply MICVDD not found, using dummy regulator
[ 7.669821] wm8904 7-001a: revision A
[ 7.689040] tegra-i2c 31e0000.i2c: Adding to iommu group 2
Corresponding to the definition in the driver WM8904.c:
static const char *wm8904_supply_names[WM8904_NUM_SUPPLIES] = {
"DCVDD",
"DBVDD",
"AVDD",
"CPVDD",
"MICVDD",
};