Bug report: 34.1.1 - 3 bugs in the kernel sourcetree tarball

[xback]

commit c1a746fad4c3465abc93d4f8fe39ee19b480f4ef (HEAD)
Author: Koen Vandeputte <koen.vandeputte@ncentric.com>
Date:   Fri Jul 15 12:18:27 2022 +0200

    fix missing guard

diff --git a/drivers/gpu/nvgpu/os/linux/platform_ga10b_tegra.c b/drivers/gpu/nvgpu/os/linux/platform_ga10b_tegra.c
index c24d664f2df3..284174a736c3 100644
--- a/drivers/gpu/nvgpu/os/linux/platform_ga10b_tegra.c
+++ b/drivers/gpu/nvgpu/os/linux/platform_ga10b_tegra.c
@@ -226,11 +226,13 @@ static int ga10b_tegra_probe(struct device *dev)
        struct device_node *of_chosen;
 #endif
 
+#ifdef CONFIG_TEGRA_GK20A_NVHOST
        err = nvgpu_nvhost_syncpt_init(platform->g);
        if (err) {
                if (err != -ENOSYS)
                        return err;
        }
+#endif
 
        platform->disable_bigpage = !iommu_get_domain_for_dev(dev) &&
                (NVGPU_CPU_PAGE_SIZE < SZ_64K);

commit a5e968270ace3472712d7b6bde95fe503e2ea33e
Author: Koen Vandeputte <koen.vandeputte@ncentric.com>
Date:   Fri Jul 15 11:49:25 2022 +0200

    remove assignment to non-existent var

diff --git a/drivers/gpu/nvgpu/os/linux/scale.c b/drivers/gpu/nvgpu/os/linux/scale.c
index b89928553c33..355eabb8f417 100644
--- a/drivers/gpu/nvgpu/os/linux/scale.c
+++ b/drivers/gpu/nvgpu/os/linux/scale.c
@@ -403,7 +403,6 @@ void gk20a_scale_init(struct device *dev)
                return;
 
        profile->dev = dev;
-       profile->dev_stat.busy = false;
 
        /* Create frequency table */
        err = gk20a_scale_make_freq_table(profile);

commit f8f6448139d7efc29f59b11a3bf989ffc3de017e (HEAD)
Author: Koen Vandeputte <koen.vandeputte@ncentric.com>
Date:   Fri Jul 15 13:34:52 2022 +0200

   fix gsp_scheduler flag setting

diff --git a/drivers/gpu/nvgpu/Makefile.shared.configs b/drivers/gpu/nvgpu/Makefile.shared.configs
index eba8d87707ae..e16988de872b 100644
--- a/drivers/gpu/nvgpu/Makefile.shared.configs
+++ b/drivers/gpu/nvgpu/Makefile.shared.configs
@@ -302,8 +302,8 @@ CONFIG_NVGPU_MIG                     := 1
 NVGPU_COMMON_CFLAGS                  += -DCONFIG_NVGPU_MIG
 
 # Enable gsp scheduler for normal build
-CONFIG_NVGPU_GSP_SCHEDULER......:= 1
-NVGPU_COMMON_CFLAGS.............+= -DCONFIG_NVGPU_GSP_SCHEDULER
+CONFIG_NVGPU_GSP_SCHEDULER      := 1
+NVGPU_COMMON_CFLAGS             += -DCONFIG_NVGPU_GSP_SCHEDULER
 
 # Enable GSP stress test
 ifeq ($(CONFIG_NVGPU_GSP_SCHEDULER),1)

[linuxdev]

You might want to add which kernel this is (release version and if downloaded from a particular L4T release or source_sync tag).

[xback]

Hi,

It’s the public source downloadable from the 34.1.1 BSP release webpage.

Regards

[DaneLLL]

Hi,
Thanks for sharing the patch. Please also share what issue you have seen. And do you see error prints in dmesg? Would like to have more information and we can check with our teams.

[xback]

Hi,

I did not boot it yet.

I ported the nvgpu parts to kernel 5.15 and noticed some compilation bugs when building.

Debugging those showed these 3 errors.

The strangest one actually is the missing var which is being assigned.

Doing a simple grep on the full tree as downloaded showed that it does not exist.
So I wonder how this one got through :)

[DaneLLL]

Hi,
Could you try default release? It is 5.10 by default and we suggest try this first. To make sure you can boot up successfully with default release.