How to do correctly define "clock-names "at jetson TX1 R28.2?

Autonomous Machines Jetson & Embedded Systems Jetson TX1
1

I have a project use imx185 sensor at jetson TX1 R28.2

How to correctly define “clock-names”this field ?

I use “clk_out_3”,or "“extperiph1”,
Which is RIGHT?

the device c source is below

static int imx185_power_get(struct imx185 *priv)
{
	struct camera_common_power_rail *pw = &priv->power;
	struct camera_common_pdata *pdata = priv->pdata;
	const char *mclk_name;
	struct clk *parent;
	int err = 0;

	mclk_name = priv->pdata->mclk_name ?
		    priv->pdata->mclk_name : "extperiph1";
	pw->mclk = devm_clk_get(&priv->i2c_client->dev, mclk_name);
	if (IS_ERR(pw->mclk)) {
		dev_err(&priv->i2c_client->dev,
			"unable to get clock %s\n", mclk_name);
		return PTR_ERR(pw->mclk);
	}

	parent = devm_clk_get(&priv->i2c_client->dev, "pllp_grtba");
	if (IS_ERR(parent))
		dev_err(&priv->i2c_client->dev, "devm_clk_get failed for pllp_grtba");
	else
		clk_set_parent(pw->mclk, parent);

	pw->reset_gpio = pdata->reset_gpio;

	pw->state = SWITCH_OFF;
	return err;
}

The dtsi file is below:

imx185_a@1a {
						/* Define any required hw resources needed by driver */
						/* ie. clocks, io pins, power sources */
						clocks = <&tegra_car TEGRA210_CLK_CLK_OUT_3>;
						clock-names = "clk_out_3";
						clock-frequency = <24000000>;
						mclk = "clk_out_3";
						reset-gpios = <&gpio CAM0_RST_L GPIO_ACTIVE_HIGH>;
					};
2

hello sensor_test,

there’s T186’s default mclk naming as extperiph1
otherwise, please following the clock in the sensor device tree.
thanks

3

Hello JerryChang,

1.The TX1 is use “tegra_car TEGRA210_CLK_CLK_OUT_3”,is RIGHT?

2.Now,at TX1,I must change the the device c source to this,is right?

static int imx185_power_get(struct imx185 *priv)
{
	struct camera_common_power_rail *pw = &priv->power;
	struct camera_common_pdata *pdata = priv->pdata;
	const char *mclk_name;
	struct clk *parent;
	int err = 0;

	mclk_name = priv->pdata->mclk_name ?
		    priv->pdata->mclk_name : "<b>clk_out_3</b>";
	pw->mclk = devm_clk_get(&priv->i2c_client->dev, mclk_name);
	if (IS_ERR(pw->mclk)) {
		dev_err(&priv->i2c_client->dev,
			"unable to get clock %s\n", mclk_name);
		return PTR_ERR(pw->mclk);
	}

	parent = devm_clk_get(&priv->i2c_client->dev, "pllp_grtba");
	if (IS_ERR(parent))
		dev_err(&priv->i2c_client->dev, "devm_clk_get failed for pllp_grtba");
	else
		clk_set_parent(pw->mclk, parent);

	pw->reset_gpio = pdata->reset_gpio;

	pw->state = SWITCH_OFF;
	return err;
}
4

hello sensor_test,

ideally, yes.

however,
according to your sensor device tree settings, you already given mclk as clk_out_3.

imx185_a@1a {
						mclk = "clk_out_3";

you may also refer to the kernel driver about how to parse the properties through sensor device tree.

sources/kernel/kernel-4.4/drivers/media/platform/tegra/camera/camera_common.c