Impossible to post issues to https://github.com/NVIDIA/CloudXR

jan-erik.vinje · January 25, 2023, 8:43am

Hi,

We discovered an issue and we wanted to post an issue on the github, but it seems the repository (GitHub - NVIDIA/CloudXR: CloudXR sample applications for streaming AR/VR/MR content from the cloud) doesnt allow external developers to post issues.

Specifically it is in this file:

github.com

NVIDIA/CloudXR/blob/master/arcore-android-sdk/samples/hello_cloudxr_c/app/src/main/cpp/CloudXRClientOptions.h

/*
 * Copyright (c) 2020, NVIDIA CORPORATION. All rights reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 * DEALINGS IN THE SOFTWARE.

This file has been truncated. show original

On line 184 it is currently like this:

AddOption("enable-ir-decoder", "ird", false, "Enable experimental ImageReader decoder on Android devices (reqs sdk >= 26)",
HANDLER_LAMBDA_FN{ mDebugFlags |= cxrDebugFlags_EnableImageReaderDecoder; return ParseStatus_Success; });

When it was like that it wasn´t possible to build it.
Commenting it out didn´t help
But when changed to to:


AddOption("enable-ir-decoder", "ird", false, "Enable experimental ImageReader decoder on Android devices (reqs sdk >= 26)",    HANDLER_LAMBDA_FN{ mDebugFlags |= cxrDebugFlags_EnableAImageReaderDecoder; return ParseStatus_Success; });

Then it worked on CloudXR 3.2 (From May 2022).

tegradave · April 27, 2023, 4:08pm

I realize this response is quite dated, but wanted to post something. :)

If all other lines were fine, there’s nothing special about that particular line that should be causing a compiler issue. I’d need to know the compiler, any specific options, and see output from build log, to even have a sense of what your particular setup is having issues with.

Eliminating the line break should have zero impact, else every line in the file would be throwing an error…

As for reporting on github, there have been many conversations over the past year about how to better engage on github, and it is possible we’ll eventually get to having issues and PRs and such, but for now it’s just a distribution point.

Reporting of issues can be done through your original contact for CloudXR, or via this forum. We’re hoping to expand/improve upon that moving forward, but haven’t had a plan, sign-off, and/or resources to do so as yet. Keep an eye out, hopefully that will change, clearly a forum isn’t great for bug reporting, you need a ‘form’ to fill out specific to CloudXR, prompting you for the information we’d need to help.