SPI TPM module support fail on jetpack 5.0.2/5.1 on jetson xavier agx

[ashingtsai]

Hi,all

I want to support SPI TPM module on AGX.
we do the setting as below
in <Linux_for_Tegra/source/kernel_src/kernel/kernel-5.10/arch/arm64/configs/defconfig>

TPM

CONFIG_HW_RANDOM_TPM=y
CONFIG_ARCH_BCM2835=y
CONFIG_HW_RANDOM_BCM2835=m
CONFIG_SPI_BCM2835=y
CONFIG_SECURITYFS=y
CONFIG_TCG_TPM=y
CONFIG_TCG_TIS_CORE=y
CONFIG_TCG_TIS_SPI=y
CONFIG_DEVPORT=y
CONFIG_HW_RANDOM=m

and in <Linux_for_Tegra/source/kernel_src/hardware/nvidia/platform/t19x/galen/kernel-dts/common/tegra194-p2888-0001-p2822-0000-common.dtsi>

spi@3210000 { /* SPI1 */
	status = "okay";
	cs-gpios = <&tegra_main_gpio TEGRA194_MAIN_GPIO(Z, 6) GPIO_ACTIVE_LOW>;  /* SPI1_CS0 */

	slb9670: spi@0{
		compatible = "infineon,slb9670";
		reg = <0>;
		spi-max-frequency = <32000000>;
		status = "okay";
		reset-gpios = <&tegra_main_gpio TEGRA194_MAIN_GPIO(A, 2) GPIO_ACTIVE_LOW>; /* GPIO04 */
		controller-data {
			nvidia,enable-hw-based-cs;
			nvidia,rx-clk-tap-delay = <0x11>;
		};
	};
	spi@1 {
		compatible = "tegra-spidev";
		reg = <0x1>;
		spi-max-frequency = <33000000>;
		controller-data {
			nvidia,enable-hw-based-cs;
			nvidia,rx-clk-tap-delay = <0x11>;
		};
	};
};

after re-build and flash image .
the target hw board is the same.but
it can work well with Jetpack4.6.0 but fail in Jetpack5.0.2/5.1

in jetpack4.6.0 can appear /dev/tpm0
but in jetpack5.0.2/5.1 the /dev/tpm0 disappear and no /dev/spidev0.0 too.
Jetpack5.0.2/5.1 don’t support TPM module?

[ashingtsai]

also in<Linux_for_Tegra/bootloader/t186ref/BCT/tegra19x-mb1-pinmux-p2888-0000-a04-p2822-0000-b01.cfg>

setting :
pinmux.0x0243d040 = 0x00000444; # spi1_sck_pz3: rsvd1, pull-down, tristate-enable, input-enable, lpdr-disable
pinmux.0x0243d020 = 0x00000444; # spi1_miso_pz4: rsvd1, pull-down, tristate-enable, input-enable, lpdr-disable
pinmux.0x0243d058 = 0x00000444; # spi1_mosi_pz5: rsvd1, pull-down, tristate-enable, input-enable, lpdr-disable
pinmux.0x0243d010 = 0x00000448; # spi1_cs0_pz6: rsvd1, pull-up, tristate-enable, input-enable, lpdr-disable
pinmux.0x0243d050 = 0x00000448; # spi1_cs1_pz7: rsvd1, pull-up, tristate-enable, input-enable, lpdr-disable

[DaneLLL]

Hi,
Please boot to Ubuntu desktop and run xxd commands to check if the device tree is expected. Such as:

nvidia@tegra-ubuntu:~$ xxd /proc/device-tree/spi@3210000/status
00000000: 6f6b 6179 00                             okay.
nvidia@tegra-ubuntu:~$ xxd /proc/device-tree/spi@3210000/spi@0/spi-max-frequency
00000000: 01f7 8a40

[ashingtsai]

here is my result.

nvidia@tegra-ubuntu:~$ cat /etc/nv_tegra_release

R35 (release), REVISION: 1.0, GCID: 31250864, BOARD: t186ref, EABI: aarch64, DATE: Thu Aug 11 03:40:29 UTC 2022

nvidia@tegra-ubuntu:~$ xxd /proc/device-tree/spi@3210000/status00000000: 6f6b 6179 00 okay.
nvidia@tegra-ubuntu:~$ xxd /proc/device-tree/spi@3210000/spi@0/spi-max-frequency00000000: 01e8 4800 …H.
nvidia@tegra-ubuntu:~$

[DaneLLL]

Hi,
Please check if the nodes are expected:

spi@3210000 { /* SPI1 */
	status = "okay";
	cs-gpios = <&tegra_main_gpio TEGRA194_MAIN_GPIO(Z, 6) GPIO_ACTIVE_LOW>;  /* SPI1_CS0 */

	slb9670: spi@0{
		compatible = "infineon,slb9670";
		reg = <0>;
		spi-max-frequency = <32000000>;
		status = "okay";
		reset-gpios = <&tegra_main_gpio TEGRA194_MAIN_GPIO(A, 2) GPIO_ACTIVE_LOW>; /* GPIO04 */
		controller-data {
			nvidia,enable-hw-based-cs;
			nvidia,rx-clk-tap-delay = <0x11>;
		};
	};
	spi@1 {
		compatible = "tegra-spidev";
		reg = <0x1>;
		spi-max-frequency = <33000000>;
		controller-data {
			nvidia,enable-hw-based-cs;
			nvidia,rx-clk-tap-delay = <0x11>;
		};
	};
};

To make sure the modification in device tree takes effect. And can compare with device tree in Xavier/Jetpack 4.6 to make sure the setting is identical on the two releases.

[ashingtsai]

the same setting works well on 4.6.0 but 5.0.2
i am sure the flash .dtb is ok

[DaneLLL]

Hi,
On Jetpack 5, certain setting is in dtbo file and probably it is not applied in device tree, so please boot to userspace and run xxd to inspect the device tree. To make sure it is same as Jetpack 4.

[ashingtsai]

Hi,DaneLLL

after build ,We use this dtb
/arch/arm64/boot/dts/nvidia/tegra194-p2888-0001-p2822-0000.dtb
is incorrect?

[b-sathishkumar]

Did you use /opt/nvidia/jetson-io/jetson-io.py to configure the SPI pins in 40 pin header ?

[ashingtsai]

I config pinmux table
I think maybe the TPM driver on jetpack4.6 can not be used on jetpack 5.0.2 linux kernel

also in<Linux_for_Tegra/bootloader/t186ref/BCT/tegra19x-mb1-pinmux-p2888-0000-a04-p2822-0000-b01.cfg>

setting :
pinmux.0x0243d040 = 0x00000444; # spi1_sck_pz3: rsvd1, pull-down, tristate-enable, input-enable, lpdr-disable
pinmux.0x0243d020 = 0x00000444; # spi1_miso_pz4: rsvd1, pull-down, tristate-enable, input-enable, lpdr-disable
pinmux.0x0243d058 = 0x00000444; # spi1_mosi_pz5: rsvd1, pull-down, tristate-enable, input-enable, lpdr-disable
pinmux.0x0243d010 = 0x00000448; # spi1_cs0_pz6: rsvd1, pull-up, tristate-enable, input-enable, lpdr-disable
pinmux.0x0243d050 = 0x00000448; # spi1_cs1_pz7: rsvd1, pull-up, tristate-enable, input-enable, lpdr-disable

[b-sathishkumar]

Little confused since you have said using tpm driver from 4.6 in 5.0.2. there is already driver in 5.0.2

We are also using the same tpm and it is working. But when we try to enable both tpm and spidev, in device tree the tpm fails. If we enable only tpm and disable spidev in device tree, then tpm works i.e., will appear as /dev/tpm0

Also please try using jetson-io.py and check. It may do some correct config which might make it work. We used it.

[DaneLLL]

Hi,
Please try the steps in
How to set gpio for spi? - #18 by DaneLLL

To make sure SPI master is working first. And then check TPM driver.

[DaneLLL]

Hi,
Please apply this patch and try again:
spi: tegra: handle cs_change in modes sw_based_cs & cs_gpios · Seeed-Studio/seeed-linux-dtoverlays@1a5db1b · GitHub

[neo.jiang]

Hi DaneLLL ,

[   15.642437] tpm_tis_spi: probe of spi0.0 failed with error -110

tpm_probe_failed.txt (20.0 KB)

[b-sathishkumar]

The error code -110 looks similar.
Try to comment the “spi@1” section in the device tree and see whether the /dev/tpm0 appears

[neo.jiang]

Hi sathishkumar,
Can you kindly share your dtsi ?

	spi@3210000 { /* SPI1 */
		status = "okay";
		cs-gpios = <&tegra_main_gpio TEGRA194_MAIN_GPIO(Z, 6) GPIO_ACTIVE_LOW>;  /* SPI1_CS0 */

		slb9670: spi@0{
			compatible = "infineon,slb9670";
			reg = <0>;
			spi-max-frequency = <32000000>;
			status = "okay";
			reset-gpios = <&tegra_main_gpio TEGRA194_MAIN_GPIO(A, 2) GPIO_ACTIVE_LOW>; /* GPIO04 */

			controller-data {
				nvidia,variable-length-transfer;
				nvidia,rx-clk-tap-delay = <31>;
            };
        };
/*
        spi@1 {
			compatible = "tegra-spidev";
			reg = <0x1>;
			spi-max-frequency = <33000000>;
			controller-data {
				nvidia,enable-hw-based-cs;
				nvidia,rx-clk-tap-delay = <0x11>;
			};
		};
*/
	};

[b-sathishkumar]

Once a fresh jetpack is installed, we followed the below steps on the Jetson
after configuring the kernel with the following configs
CONFIG_TCG_TPM=y
CONFIG_TCG_TIS_CORE=y
CONFIG_TCG_TIS_SPI=y

1. run “sudo /opt/nvidia/jetson-io/jetson-io.py” and configure the 40-pin header for SPI1 pins and then save.

2. use dtc to convert from dtb to dts the dtb file specified in FDT in /boot/extlinux/extlinux.conf

3. once converted to dts, update the following to the dts file

   spi@3210000 {
            compatible = "nvidia,tegra186-spi";
            reg = <0x00 0x3210000 0x00 0x10000>;
            interrupts = <0x00 0x24 0x04>;
            #address-cells = <0x01>;
            #size-cells = <0x00>;
            iommus = <0x02 0x20>;
            dma-coherent;
            dmas = <0x24 0x0f 0x24 0x0f>;
            dma-names = "rx\0tx";
            spi-max-frequency = <0x3dfd240>;
            nvidia,clk-parents = "pll_p\0clk_m";
            clocks = <0x04 0x87 0x04 0x66 0x04 0x0e>;
            clock-names = "spi\0pll_p\0clk_m";
            resets = <0x04 0x5b>;
            reset-names = "spi";
            status = "okay";
            phandle = <0x2f7>;
   
            prod-settings {
   
                    prod_c_cs0 {
                            prod = <0x04 0xfff 0x11>;
                    };
            };
   
            slb9670@0 {
                    compatible = "tcg,tpm_tis-spi";
                    reg = <0x0>;
                    #address-cells = <1>;
                    #size-cells = <0>;
                    spi-max-frequency = <5000000>;
                    status = "okay";
                    controller-data {
                            nvidia,enable-hw-based-cs;
                    };
            };
   

/*
spi@1 {
compatible = “tegra-spidev”;
reg = <0x1>;

4. use dtc again to convert dts to dtb and update the FDT filename in /boot/extlinux/extlinux.conf to the updated dtb file

[ashingtsai]

Hi sathishkumar

than you very much for your reply.
but may I know do your TPM work well on jetpack version 5.0.2/5.1 or just on jetpack4.6.x version ?
because our TPM can works well on jetpack4.6.x but fail on 5.0.2/5.1.

[b-sathishkumar]

We tried on 5.0.2/5.1 only. We didn’t try on 4.6.x

[jack_lan]

Hi b-sathishkumar

May I ask whether the TPM you use is SLB9670 or SLB9672?

Or is there a way to measure the behavior of the CS pin?

Because the problem we have is that when we use “nvidia,enable-hw-based-cs”, the behavior of the cs pin is not as required by SLB9672. We have confirmed this with Infineon’s FAE.

The waveforms we measured and the problems we encountered have opened another question on the following website, but no one has answered so far.

SPI infineon TPM 2.0 cs-gpios not correct work on Jetpack 5.0.2 and 5.1

Hi all We recently upgraded Xavier AGX from Jetpack 4.6 to 5.0.2 or even 5.1 Among them, the function of SPI TPM has been able to work normally in Jetpack 4.6. However, when we upgraded to 5.0.2, we found that the TPM, which was working normally, could not be initialized. We have confirmed the status of the Pinmux spi register with busybox, and also confirmed that the SPI pins are not occupied by other devices in the Device Tree. By measuring the SPI pin signal and comparing the status of J…

Best Regards
Jack Lan